[vlc-devel] [PATCH 1/3] avcodec:video: don't try hardware acceleration if "none" is enabled

[Rémi Denis-Courmont]

Le 7 août 2017 00:09:40 GMT+03:00, Jean-Baptiste Kempf <jb at videolan.org> a écrit :
>Hello,
>
>On Fri, 4 Aug 2017, at 17:17, Jean-Baptiste Kempf wrote:
>> On Fri, 4 Aug 2017, at 17:15, Rémi Denis-Courmont wrote:
>> 
>>> 
>>> If you mean avcodec hwaccel, then there are infinitely many ways to
>>> enable or disable.> 
>> avcodec-hw=none, yes
>
>As this is what gets written when you save the preferences, I guess
>--avcodec-
>hw=none is the correct way.
>--
>Jean-Baptiste Kempf -  President
>+33 672 704 734
> 

The correct way is to check the module loader return value, in other words what is already done.

We have had bugs with this exact same variable attempting the exact kludge in the past.
-- 
Rémi Denis-Courmont
Typed on an inconvenient virtual keyboard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170807/c6367253/attachment.html>