[vlc-devel] [PATCH 07/11] macosx: handle the flag in VOUT_DISPLAY_HIDE_MOUSE

[Steve Lhomme]

You're right.

See the context here: https://trac.videolan.org/vlc/ticket/18658

But until we remove VOUT_DISPLAY_HIDE_MOUSE from there, it's better if
it does what it's supposed to do.

On Tue, Aug 8, 2017 at 4:31 PM, Marvin Scholz <epirat07 at gmail.com> wrote:
> On 8 Aug 2017, at 15:22, Steve Lhomme wrote:
>
>> In case it's ever used.
>> ---
>>  modules/video_output/macosx.m | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/modules/video_output/macosx.m b/modules/video_output/macosx.m
>> index dd132fef20..fe044bbb1a 100644
>> --- a/modules/video_output/macosx.m
>> +++ b/modules/video_output/macosx.m
>> @@ -416,7 +416,10 @@ static int Control (vout_display_t *vd, int query,
>> va_list ap)
>>
>>              case VOUT_DISPLAY_HIDE_MOUSE: /* FIXME: dead code */
>>              {
>> -                [NSCursor setHiddenUntilMouseMoves: YES];
>> +                if (va_arg(args, int))
>> +                    [NSCursor hide];
>> +                else
>> +                    [NSCursor unhide];
>>                  return VLC_SUCCESS;
>>              }
>>
>> --
>> 2.12.1
>
>
> Shouldn't this be done in the vout window controller instead of the the vout
> view?
> And I am not sure if we really want to hide the cursor that way, I
> personally would
> prefer setHiddenUntilMouseMoves, as it is much more user friendly (mouse
> will show again
> as soon as it is moved) and you do not have to worry about unbalanced calls
> to hide/unhide.
>
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel