[vlc-devel] [PATCH 07/11] macosx: handle the flag in VOUT_DISPLAY_HIDE_MOUSE

[Rémi Denis-Courmont]

Le tiistaina 8. elokuuta 2017, 18.37.06 EEST David Fuhrmann a écrit :
> Hello all,
> 
> If I remember correctly, the complex part is the following:
> If the mouse is over the fullscreen control, it was not hidden, even if the
> timer fired already. This seems to be hard to implement with the core
> generated events, therefore the interface module had / has some own
> implementation of the mouse hiding logic.

If the windowing system is half-way sane, it keeps track of cursor images per 
window. The video window should be able to hide the cursor, or to set a fully 
transparent one even when it is not in focus.

If the windowing system is insane, then you have to track the focus entry 
event to show or hide the cursor, so it gets a little bit complicated indeed.

> If we want to keep that feature, I would be in favor of removing the
> implementation from vout plugin (and also not using the event in window
> plugin), and continue doing the logic in the macOS interface itself.

I´m not sure what is the distinction between the window plugin and the MacOS 
interface, given that the window plugin should be part of the interface. But 
either way, I agree that it´s simpler to handle the cursor image within 
plugins and ignore VOUT_*_HIDE_MOUSE controls altogether.

But then you should remove the dead code.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/