[vlc-devel] [PATCH 1/2] access{_out}:srt: introduce SRT input/ouput

[Rémi Denis-Courmont]

Le 8 août 2017 23:52:31 GMT+03:00, Jean-Baptiste Kempf <jb at videolan.org> a écrit :
>Hello Justin
>
>On Tue, 8 Aug 2017, at 22:12, Justin Kim wrote:
>> I can't find proper documents to use them.
>
>See m4/vlc.m4 or the numerous examples of configure.ac:
>
>PKG_ENABLE_MODULES_VLC([DCA], [dca], [libdca >= 0.0.5], [DTS Coherent
>Acoustics support with libdca], [auto])
>
>> Which script? I can't find document.
>
>modules/list.sh
>
>> >> +dnl
>> >> +dnl  SRT plugin
>> >> +dnl
>> >> +AC_ARG_ENABLE(srt,
>> >> +[AS_HELP_STRING([--disable-srt],[srt input/output plugin (default
>> >> auto)])])
>> >> +have_srt="no"
>> >> +AS_IF([test "${enable_srt}" != "no"], [
>> >> +    PKG_CHECK_MODULES(SRT, [srt >= 1.2.0], [
>> >> +        have_srt="yes"
>> >> +        AC_CHECK_HEADER([srt/srt.h], [
>> >> +            VLC_ADD_PLUGIN([srt])
>> >> +            VLC_ADD_CXXFLAGS([srt], [$SRT_CFLAGS])
>> >> +            VLC_ADD_CFLAGS([srt], [$SRT_CFLAGS])
>> >> +            VLC_ADD_LIBS([srt], [$SRT_LIBS])
>> >> +        ], [
>> >> +            AS_IF([test -n "${enable_srt}"],
>> >> +                [AC_MSG_ERROR([${SRT_PKG_ERRORS} (required for
>srt).])],
>> >> +                [AC_MSG_WARN([${SRT_PKG_ERRORS} (required for
>srt).])]
>> >> +                )
>> >> +        ])
>> >> +    ], [
>> >> +        AS_IF([test "x${enable_srt}" = "xyes"],
>> >> +            [AC_MSG_ERROR([${SRT_PKG_ERRORS} (required for
>srt).])],
>> >> +            [AC_MSG_WARN([${SRT_PKG_ERRORS} (required for
>srt).])]
>> >> +            )
>> >> +    ])
>> >> +])
>> >> +AM_CONDITIONAL([HAVE_SRT], [test "${have_srt}" = "yes"])
>> > Why not using the PKG_VLC macro ? Is that not possible ?
>> I don't find PKG_VLC macro. Where is it?
>
>See above.
>
>For you, it will probably be something like this:
>PKG_ENABLE_MODULES_VLC([SRT], [srt], [srt >= 1.2.0], [Secure Reliable
>Transport support], [auto])
>
>> >> diff --git a/modules/access/srt.c b/modules/access/srt.c
>
>-- 
>Jean-Baptiste Kempf -  President
>+33 672 704 734
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

AFAIK, we do not have a helper that would output a makefile condition. We only have variable substitution. So it won't work, especially with the second patch.
-- 
Rémi Denis-Courmont
Typed on an inconvenient virtual keyboard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170809/aed637ca/attachment.html>