[vlc-devel] [PATCH v2 04/11] qt: use vlc_actions

[Rémi Denis-Courmont]

Le keskiviikkona 9. elokuuta 2017, 18.16.28 EEST Hugo Beauzée-Luyssen a 
écrit :
> From: Thomas Guillem <thomas at gllm.fr>
> 
> ---
>  modules/gui/qt/actions_manager.cpp | 35 +++++---------------
>  modules/gui/qt/input_manager.cpp   | 65
> ++++++++++---------------------------- modules/gui/qt/qt.hpp              |
>  1 +
>  3 files changed, 25 insertions(+), 76 deletions(-)
> 
> diff --git a/modules/gui/qt/actions_manager.cpp
> b/modules/gui/qt/actions_manager.cpp index cc67ff1c0d..9bc81da7a3 100644
> --- a/modules/gui/qt/actions_manager.cpp
> +++ b/modules/gui/qt/actions_manager.cpp
> @@ -125,11 +125,10 @@ void ActionsManager::play()
>   */
>  void ActionsManager::fullscreen()
>  {
> -    bool fs = var_ToggleBool( THEPL, "fullscreen" );
>      vout_thread_t *p_vout = THEMIM->getVout();
> -    if( p_vout)
> +    if( p_vout )
>      {
> -        var_SetBool( p_vout, "fullscreen", fs );
> +        ACTION_DO( ACTIONID_TOGGLE_FULLSCREEN, 1, p_vout );
>          vlc_object_release( p_vout );

Again, I don´t see any rationale nor any obvious reason for this change and 
those below.

The hoykeys system was meant to handle, well, hotkeys. It then abused/extended 
to support generic dispatch, which is a nice hack for scripting.
But why here??


-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/