[vlc-devel] [PATCH] vout: Also set the initial vout window fullscreen state on HWND platforms

[Rémi Denis-Courmont]

Le 10 août 2017 12:49:24 GMT+03:00, "Hugo Beauzée-Luyssen" <hugo at beauzee.fr> a écrit :
>Fix #18672
>---
> src/video_output/video_output.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/src/video_output/video_output.c
>b/src/video_output/video_output.c
>index be1249a2b2..c432c70aa0 100644
>--- a/src/video_output/video_output.c
>+++ b/src/video_output/video_output.c
>@@ -166,9 +166,7 @@ static vout_thread_t *VoutCreate(vlc_object_t
>*object,
>     if (vout->p->splitter_name == NULL) {
>         vout_window_cfg_t wcfg = {
>             .is_standalone = !var_InheritBool(vout, "embedded-video"),
>-#if !defined(_WIN32) && !defined(__OS2__)
>             .is_fullscreen = var_GetBool(vout, "fullscreen"),
>-#endif
>             .type = VOUT_WINDOW_TYPE_INVALID,
>             // TODO: take pixel A/R, crop and zoom into account
> #ifdef __APPLE__
>-- 
>2.11.0
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

I think that the CPP logic is inverted. This would account for not going fullscreen. But this does not account for the reported error message on Trac. So it sounds lile there is an extra latent bug somewhere else.
-- 
Rémi Denis-Courmont
Typed on an inconvenient virtual keyboard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170810/a3f31216/attachment.html>