[vlc-devel] [vlc-commits] display: no need for a local video_format_t with VOUT_DISPLAY_CHANGE_SOURCE_ASPECT

[Steve Lhomme]

On Thu, Aug 10, 2017 at 7:58 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le perjantaina 4. elokuuta 2017, 15.57.22 EEST Steve Lhomme a écrit :
>> vlc | branch: master | Steve Lhomme <robux4 at videolabs.io> | Wed Aug  2
>> 09:33:35 2017 +0200| [141eee707daf6096b339d649771612a52a1ee043] |
>> committer: Rémi Denis-Courmont
>>
>> display: no need for a local video_format_t with
>> VOUT_DISPLAY_CHANGE_SOURCE_ASPECT
>>
>> Receivers don't check the difference with the original value, they just
>> apply the new value.
>
> Except the Wayland video output does use the original value.

Ah indeed. But as discussed with these patches. If a vout depends on
the previous state when told a new aspect-ratio/crop comes in. It's
his business to deal with it.

> Please revert this and next.

IMO it's better to fix wayland/shm.c I'll give it a try but have no
way of testing.

> --
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel