[vlc-devel] [PATCH] canvas: handle filter_chain_AppendConverter return-code correctly

Thomas Guillem thomas at gllm.fr
Mon Aug 28 13:29:21 CEST 2017


Good catch, I'll merge it

On Mon, Aug 28, 2017, at 13:12, Ilkka Ollakka wrote:
> ---
>  modules/video_filter/canvas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/video_filter/canvas.c
> b/modules/video_filter/canvas.c
> index f47538ed16..41fe4766ac 100644
> --- a/modules/video_filter/canvas.c
> +++ b/modules/video_filter/canvas.c
> @@ -330,7 +330,7 @@ static int Activate( vlc_object_t *p_this )
>  
>      filter_chain_Reset( p_sys->p_chain, &p_filter->fmt_in, &fmt );
>      /* Append scaling module */
> -    if ( !filter_chain_AppendConverter( p_sys->p_chain, NULL, NULL ) )
> +    if ( filter_chain_AppendConverter( p_sys->p_chain, NULL, NULL ) )
>      {
>          msg_Err( p_filter, "Could not append scaling filter" );
>          free( p_sys );
> -- 
> 2.14.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list