[vlc-devel] [vlc-commits] demux: make p_sys void * (refs #18504, #17078)

[Steve Lhomme]

On Mon, Dec 4, 2017 at 10:18 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le 4 décembre 2017 09:31:04 GMT+02:00, Steve Lhomme <robux4 at gmail.com> a écrit :
>>On Sun, Dec 3, 2017 at 4:58 PM, Rémi Denis-Courmont <git at videolan.org>
>>wrote:
>>> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun
>>Dec  3 17:54:47 2017 +0200| [d1f94520de68ced8ded5b622c8fb94ca4e7f49cf]
>>| committer: Rémi Denis-Courmont
>>>
>>> demux: make p_sys void * (refs #18504, #17078)
>>>
>>>>
>>http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d1f94520de68ced8ded5b622c8fb94ca4e7f49cf
>>> ---
>>>
>>>  include/vlc_demux.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/vlc_demux.h b/include/vlc_demux.h
>>> index c305e8ccd3..fda7cecff5 100644
>>> --- a/include/vlc_demux.h
>>> +++ b/include/vlc_demux.h
>>> @@ -88,7 +88,7 @@ struct demux_t
>>>          unsigned int i_update;  /* Demux sets them on change,
>>>                                     Input removes them once take into
>>account*/
>>>      } info;
>>> -    demux_sys_t *p_sys;
>>> +    void *p_sys;
>>
>>I don't see the improvement. I can see a major PITA to use it now.
>>
>>>      /* Weak link to parent input */
>>>      input_thread_t *p_input;
>>>
>>> _______________________________________________
>>> vlc-commits mailing list
>>> vlc-commits at videolan.org
>>> https://mailman.videolan.org/listinfo/vlc-commits
>>_______________________________________________
>>vlc-devel mailing list
>>To unsubscribe or modify your subscription options:
>>https://mailman.videolan.org/listinfo/vlc-devel
>
> I don't get to decide how C(++) works, and you don't either. The justification references were provided in the commit,

I don't any commit that fix the ODR issue. All modules are compiled
separately so for each demux_sys_t is already only defined once. If
you're talking about a static build then the multiple demux_sys_t in
C++ modules are still there unchanged.

> but thanks for being a dick.

https://wiki.videolan.org/Code_of_Conduct/
"Do not use foul language, and absolutely NO insults will be tolerated. "


> If you don't like how it is a PITA in C++, you are more than welcome to switch to C, which is the official language for VLC still.
> --
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel