[vlc-devel] [vlc-commits] demux: make p_sys void * (refs #18504, #17078)

[Steve Lhomme]

On Mon, Dec 4, 2017 at 4:21 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> Hello,
>
> On Mon, 4 Dec 2017, at 16:12, Steve Lhomme wrote:
>> I did read both issues before sending my first comment. I think using
>> void* is the wrong solution to both problems. And that's what I said.
>
> What do you suggest to solve the ODR issue ?

This patch(es) don't solve the ODR issue. The issue it solves is
merging the structures into one.
You could use :

union {
  demux_sys_t *p_sys_demux;
  access_sys_t *p_sys_access;
 ...
};

And keep the strong typing.

> --
> Jean-Baptiste Kempf -  President
> +33 672 704 734
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel