[vlc-devel] [PATCH 6/6] ftp: use vlc_UrlParseFixup

Thomas Guillem thomas at gllm.fr
Tue Dec 5 11:06:37 CET 2017


On Tue, Dec 5, 2017, at 10:38, Bang He wrote:
> the function vlc_UrlParseFixup is so big

Hello,

I don't understand your review.

> 
> On Tue, Dec 5, 2017 at 4:52 PM, Thomas Guillem <thomas at gllm.fr> wrote:>> Refs #18991
>>  ---
>>   modules/access/ftp.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>>  diff --git a/modules/access/ftp.c b/modules/access/ftp.c
>>  index 79387772a3..fd486831cb 100644
>>  --- a/modules/access/ftp.c
>>  +++ b/modules/access/ftp.c
>>  @@ -443,7 +443,7 @@ static int Login( vlc_object_t *p_access,
>>  access_sys_t *p_sys )>> 
>>       vlc_url_t url;
>>       vlc_credential credential;
>>  -    vlc_UrlParse( &url, ((stream_t *)p_access)->psz_url );
>>  +    vlc_UrlParseFixup( &url, ((stream_t *)p_access)->psz_url );
>>       vlc_credential_init( &credential, &url );
>>       bool b_logged = false;
>> 
>>  @@ -645,7 +645,7 @@ static int parseURL( vlc_url_t *url, const char
>>  *path, enum tls_mode_e mode )>>       while( *path == '/' )
>>           path++;
>> 
>>  -    vlc_UrlParse( url, path );
>>  +    vlc_UrlParseFixup( url, path );
>> 
>>       if( url->psz_host == NULL || *url->psz_host == '\0' )
>>           return VLC_EGENERIC;
>> --
>>  2.11.0
>>
>>  _______________________________________________
>>  vlc-devel mailing list To unsubscribe or modify your subscription
>>  options: https://mailman.videolan.org/listinfo/vlc-devel> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20171205/4bc2dd5d/attachment.html>


More information about the vlc-devel mailing list