[vlc-devel] [PATCH 1/3] coreaudio: fix possible deadlock on pause
thomas at gllm.fr
Sat Dec 9 15:28:43 CET 2017
On Fri, Dec 8, 2017, at 19:21, Rémi Denis-Courmont wrote:
> Le perjantaina 8. joulukuuta 2017, 18.33.25 EET Thomas Guillem a écrit :
> > On Fri, Dec 8, 2017, at 18:26, Rémi Denis-Courmont wrote:
> > > No. Even then, that obviously can't work correctly.
> > Why ? I double checked, it works for me.
> Logically, that´s impossible with the current API.
I'm sorry but I really don't understand this conversation.
1/ You say that the 1/2 patch is useless since Pause can't be called
while the audio output is in Play or Flush
2/ Caro says that the commit log of the 1/2 patch is misleading and that
the second patch adds a call to ca_Pause() from a random thread
3/ You say it obviously can't work
4/ I ask why
5/ You repeat your first remark
Here, ca_Pause is the pause callback for macOS and iOS audio outputs.
With the patch 2/2, this function can be called from a random thread
when the audio session is disabled (and when the audio render callback
is shut down) and will unstuck flush/play.
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel