[vlc-devel] [PATCH 1/3] coreaudio: fix possible deadlock on pause

[Rémi Denis-Courmont]

Le lauantaina 9. joulukuuta 2017, 15.53.05 EET Thomas Guillem a écrit :
> On Sat, Dec 9, 2017, at 15:48, Rémi Denis-Courmont wrote:
> > Le lauantaina 9. joulukuuta 2017, 15.28.43 EET Thomas Guillem a écrit :
> > > Here, ca_Pause is the pause callback for macOS and iOS audio outputs.
> > > With the patch 2/2, this function can be called from a random thread
> > > when the audio session is disabled (and when the audio render callback
> > > is shut down) and will unstuck flush/play.
> > 
> > And I don't see how that can work. The interface is not reentrant so its
> > implementation can´t be reentrant either.
> 
> The interface is not reentrant, but the implementation is with this
> patch.

That is not logically possible (except for degenerate implementation such as 
no-ops).

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/