[vlc-devel] [PATCH] coreaudio: fix deadlock on interruption

Rémi Denis-Courmont remi at remlab.net
Tue Dec 12 17:21:49 CET 2017

Le tiistaina 12. joulukuuta 2017, 16.18.15 EET Thomas Guillem a écrit :
> > Also mixing atomic ops and muteces smells very bad, TBH.
> I said to Caro to do it like that. I agree it smells bad and seems
> complicated.

That was a polite way to say that it makes no sense.

Indeed, a quick look at the code shows that the atomic vars don't make sense. 
Also the circular buffer is busted.

> I invite you to take a closer at ca_Flush (in the drain == false case)
> and ca_SetAliveState(). For me, it's thread safe.

So you wasted my time, and now you want to review again. How about, hell no?


More information about the vlc-devel mailing list