[vlc-devel] [PATCH] coreaudio: fix deadlock on interruption

Carola Nitz nitz.carola at googlemail.com
Tue Dec 12 18:50:22 CET 2017

>>> I invite you to take a closer at ca_Flush (in the drain == false case)
>>> and ca_SetAliveState(). For me, it's thread safe.
>> So you wasted my time, and now you want to review again. How about, hell
>> no?

First off I learned quite a bit from this review and highly appreciate it.

So correct me if I’m wrong, but we both want to spent less time on reviews here and do it right correct ?
To avoid another “obviously wrong patch”, (wasting my time in creating it and yours in reviewing it) would it be possible that you could just tell me how to do it instead ?

You really started off great by saying “ checking pause within Flush is ..wrong, these things should be orthogonal.” I really hoped for a follow up like “you could achieve this by adding/checking ..."
So how can we avoid this whole atomic, mutex mess ? How do we get it orthogonal ?

- Caro

More information about the vlc-devel mailing list