[vlc-devel] [PATCH] configure: do not sanitize vptr

Filipe Cabecinhas vlc at filcab.net
Mon Dec 18 02:05:26 CET 2017


How broken is it, in what platform? Is rtti enabled/disabled throughout, or
are there different rtti configurations for different libraries?

Thank you,

 Filipe

On Sun, 17 Dec 2017 at 20:36, RĂ©mi Denis-Courmont <remi at remlab.net> wrote:

> This is notoriously broken in UBSan, causing a lot of false positives
> with TagLib.
> ---
>  configure.ac | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index acbee6c0b1..57c2f091f3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1037,6 +1037,9 @@ AS_VAR_IF(with_sanitizer, no, [], [
>          AX_APPEND_COMPILE_FLAGS([-fPIE -pie])
>          AX_APPEND_COMPILE_FLAGS([-fPIE -pie], [CXXFLAGS])
>      ])
> +    AS_IF([test -z "${with_sanitizer##*undefined*}" ], [
> +        AX_APPEND_COMPILE_FLAGS([-fno-sanitize=vptr], [CXXFLAGS])
> +    ])
>  ])
>
>  dnl
> --
> 2.15.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20171218/665cf7cf/attachment.html>


More information about the vlc-devel mailing list