[vlc-devel] [PATCH] qt(wayland): patches to fix video display issues

[Thomas Guillem]

On Mon, Dec 18, 2017, at 10:30, Thomas Guillem wrote:
> 
> 
> On Sun, Dec 17, 2017, at 23:29, Jean-Baptiste Kempf wrote:
> > Hello,
> > 
> > On Fri, 15 Dec 2017, at 19:55, erwan.tulou at gmail.com wrote:
> > >     patch1: videowidget management when undocking the playlist
> > >     This patch fixes a crash for Wayland and incidentally also benefits 
> > > other platforms. The patch should not pose a problem.
> > 
> > Applied.
> > 
> > >     patch2: fix qt crash when toggling between playlist and full screen 
> > > in the main window
> > >     This patch is a not-so-clean hack, but the only way to solve a 
> > > current qt limitation without major redesign. The only good reason to 
> > > apply the patch is that it fixes a very conspicuous crash within the 
> > > main window.
> > 
> > It's not too ugly, tbh, but I am not sure.
> > 
> > >     patch3: EGL/wayland issue
> > >     I know this patch is badly regarded, but since Opengl is the default 
> > > vout display, something has to be done to fix it. I fail to see any 
> > > problem, but I leave it up to you to apply it or come up with a better 
> > > solution.
> > 
> > Thomas?
> 
> I need to to test on a wayland system and look at the
> wl_egl_window_resize documentation.
> For info, vlc_gl_Resize is only used by EGL WL, so this patch won't have
> any impacts on other platforms/gl plugins.

I'm OK with the patch 3. It simply doesn't work without it.

> 
> > 
> > >    patch4: width/height with null value
> > >    This patch is an easy way to sweep the problem under the carpet ! It 
> > > does fix crashes, but may hide some other issues.  The patch is to be 
> > > applied if fixing another conspicuous crash right away is important, or 
> > > wait till a better long term solution is found.
> > 
> > For me, this patch feels wrong, but I need to check again.
> > 
> > -- 
> > Jean-Baptiste Kempf -  President
> > +33 672 704 734
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel