[vlc-devel] [PATCH 00/11] DTSHD: VLC 3.0 backport request
thomas at gllm.fr
Tue Dec 19 15:11:15 CET 2017
On Tue, Dec 19, 2017, at 12:38, Thomas Guillem wrote:
> - Why now just before the release ?
> Because we received the first reports of DTS core not working at all via
> passthrough. Since we didn't find a proper way in the past to differentiate
> DTSHD from DTS, I decided to always send DTS core inside DTS-HD frames. The
> problem is that it just doesn't want with some HDMI receivers.
> We have 2 Amplifiers at the office, indeed, it's working for one but not for
> the other.
> - But you already proposed this kind of patches ?
> Yes I know, DTSHD is not really a new fourcc since it's backward compatible
> with DTS. The only other way I found to differentiate DTS with DTSHD is the
> bitrate. DTS core has a bitrate of 1535kb/s maximum. With DTS extensions, it's
> always more.
This is false, you can have DTS-HD with a bitrate of 1.5Mpbs.
I guess the best solution is this one or having a sub_format (that will be dtsc, dtsl, dtsh, or dtse) inside audio_format_t.
> Problem, the audio output modules don't have this information
> (audio_format_t vs es_format_t). If you want me to put the bitrate inside the
> audio_format_t instead, I can do it.
> PS: pulseaudio/android not tested with this patch set, I'll do it before
> pushing if we all agree on something.
> Thomas Guillem (13):
> core: add VLC_CODEC_DTSHD fourcc
> packetizer: dts: set DTSHD fourcc if input has substreams
> mp4: handle VLC_CODEC_DTSHD
> ts: handle VLC_CODEC_DTSHD
> ps: handle VLC_CODEC_DTSHD
> codec: spdif: handle VLC_CODEC_DTSHD
> codec: avcodec: handle VLC_CODEC_DTSHD
> codec: mft: handle VLC_CODEC_DTSHD
> converter: tospdif: handle VLC_CODEC_DTSHD
> aout: adummy: handle VLC_CODEC_DTSHD
> aout: audiotrack: handle VLC_CODEC_DTSHD
> aout: handle VLC_CODEC_DTSHD
> aout: mmdevice: handle VLC_CODEC_DTSHD
> include/vlc_aout.h | 1 +
> include/vlc_fourcc.h | 1 +
> modules/audio_filter/converter/tospdif.c | 3 +++
> modules/audio_output/adummy.c | 1 +
> modules/audio_output/audiotrack.c | 13 ++++++++-----
> modules/audio_output/mmdevice.c | 7 ++++++-
> modules/audio_output/pulse.c | 1 +
> modules/audio_output/wasapi.c | 28 +++++++---------------------
> modules/codec/avcodec/fourcc.c | 1 +
> modules/codec/mft.c | 1 +
> modules/codec/spdif.c | 1 +
> modules/demux/mp4/essetup.c | 4 +++-
> modules/demux/mpeg/ps.h | 2 +-
> modules/demux/mpeg/ts_psi.c | 3 ++-
> modules/packetizer/dts.c | 4 +++-
> 15 files changed, 40 insertions(+), 31 deletions(-)
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel