[vlc-devel] [RFC PATCH 0/7] Add win32 breakpad support

[Jean-Baptiste Kempf]

Hello,

That looks really cool and useful. LGTM.


On Wed, 20 Dec 2017, at 11:34, Hugo Beauzée-Luyssen wrote:
> This patchset adds support for breakpad on windows.
> There might be minor adjustments to be done (most likely using a more recent
> breakpad version in contribs), but the main code is here.
> Switching to C++ might not be required, but would cause us to introduce an
> extra static library, I'm not sure it's worth it, and actually find the
> switch to C++ simpler and clearer here.
> 
> 1st patch is obviously not meant to be pushed, but should you want to try the
> patchset, you can.
> 
> Hugo Beauzée-Luyssen (7):
>   qt: Add a way to test breakpad
>   contrib: Allow breakpad to be built on windows
>   Rework breakpad detection to enable it on windows as well
>   winvlc: Remove old crash handling code
>   bin: Convert winvlc to C++
>   win32: Use breakpad for error reporting
>   configure: Specify a build ID when building with breakpad
> 
>  bin/Makefile.am                     |  13 +-
>  bin/winvlc.c                        | 470 ------------------------------------
>  bin/winvlc.cpp                      | 330 +++++++++++++++++++++++++
>  configure.ac                        |  33 +--
>  contrib/src/breakpad/rules.mak      |   6 +
>  modules/gui/qt/dialogs_provider.cpp |   6 +
>  modules/gui/qt/dialogs_provider.hpp |   2 +
>  modules/gui/qt/menus.cpp            |   3 +
>  8 files changed, 376 insertions(+), 487 deletions(-)
>  delete mode 100644 bin/winvlc.c
>  create mode 100644 bin/winvlc.cpp
> 
> -- 
> 2.11.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


-- 
Jean-Baptiste Kempf -  President
+33 672 704 734