[vlc-devel] [RFC PATCH 1/7] qt: Add a way to test breakpad

[Hugo Beauzée-Luyssen]

On Wed, Dec 20, 2017, at 12:15 PM, Marvin Scholz wrote:
> 
> 
> On 20 Dec 2017, at 11:34, Hugo Beauzée-Luyssen wrote:
> 
> > ---
> >  modules/gui/qt/dialogs_provider.cpp | 6 ++++++
> >  modules/gui/qt/dialogs_provider.hpp | 2 ++
> >  modules/gui/qt/menus.cpp            | 3 +++
> >  3 files changed, 11 insertions(+)
> >
> > diff --git a/modules/gui/qt/dialogs_provider.cpp 
> > b/modules/gui/qt/dialogs_provider.cpp
> > index edf42665aa..0c418d078a 100644
> > --- a/modules/gui/qt/dialogs_provider.cpp
> > +++ b/modules/gui/qt/dialogs_provider.cpp
> > @@ -528,6 +528,12 @@ void DialogsProvider::simpleOpenDialog()
> >      addFromSimple( true, true ); /* Playlist and Go */
> >  }
> >
> > +void DialogsProvider::testBreakpad()
> > +{
> > +    int* foo = NULL;
> > +    *foo = 0xDEADBEEF;
> > +}
> > +
> >  /* Url & Clipboard */
> >  /**
> >   * Open a MRL.
> > diff --git a/modules/gui/qt/dialogs_provider.hpp 
> > b/modules/gui/qt/dialogs_provider.hpp
> > index 4d65c7a599..013b0b8796 100644
> > --- a/modules/gui/qt/dialogs_provider.hpp
> > +++ b/modules/gui/qt/dialogs_provider.hpp
> > @@ -155,6 +155,8 @@ public slots:
> >
> >      void simpleOpenDialog();
> >
> > +    void testBreakpad();
> > +
> >      void openDialog();
> >      void openDiscDialog();
> >      void openFileDialog();
> > diff --git a/modules/gui/qt/menus.cpp b/modules/gui/qt/menus.cpp
> > index ede795a55c..0cb47a7032 100644
> > --- a/modules/gui/qt/menus.cpp
> > +++ b/modules/gui/qt/menus.cpp
> > @@ -402,6 +402,9 @@ QMenu *VLCMenuBar::FileMenu( intf_thread_t 
> > *p_intf, QWidget *parent, MainInterfa
> >
> >      addDPStaticEntry( menu, qtr( "&Quit" ) ,
> >          ":/menu/exit.svg", SLOT( quit() ), "Ctrl+Q" );
> > +
> > +    addDPStaticEntry( menu, qtr( "Test breakpad" ),
> > +        ":/menu/exit.svg", SLOT( testBreakpad() ) );
> >      return menu;
> >  }
> >
> 
> Shouldn't this only be there is not NDEBUG, maybe,
> so that we do not have that in releases?
> 

This is solely if you want to try the patchset, but no way this gets pushed :D

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr