[vlc-devel] [PATCH 5/9] es_format: check i_profile similarity for audio

[Thomas Guillem]

On Wed, Dec 20, 2017, at 19:27, Rémi Denis-Courmont wrote:
> Le keskiviikkona 20. joulukuuta 2017, 14.12.41 EET Thomas Guillem a écrit :
> > ---
> >  src/misc/es_format.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/src/misc/es_format.c b/src/misc/es_format.c
> > index 9ed9815814..1c9a78e1a4 100644
> > --- a/src/misc/es_format.c
> > +++ b/src/misc/es_format.c
> > @@ -589,6 +589,8 @@ bool es_format_IsSimilar( const es_format_t *p_fmt1,
> > const es_format_t *p_fmt2 ) a1.i_physical_channels !=
> > a2.i_physical_channels ||
> >              a1.i_chan_mode != a2.i_chan_mode )
> >              return false;
> > +        if( p_fmt1->i_profile != p_fmt2->i_profile )
> > +            return false;
> >          return true;
> >      }
> 
> That looks like a Very Bad Idea. I would be surprised if this did not break 
> something is stream output or such.

I double checked (because I want to backport to 3.0), this i_profile was only used for video (and badly by mpegaudio.c). Doing such change for VIDEO_ES is indeed more dangerous.

> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel