[vlc-devel] [PATCH] contribs: gcrypt: Make sure that a git repo is available during reconfigure

Martin Storsjö martin at martin.st
Thu Dec 21 10:48:16 CET 2017

Without this, when reconfiguring, BUILD_FILEVERSION will end up with
a trailing comma with no revision number, which means that
src/versioninfo.rc will have a syntax error on build.

To reproduce/understand, download the plain gcrypt tarball;
configure contains a line like this:
After running configure, src/versioninfo.rc contains
"FILEVERSION 1,7,8,45409".

If running autoreconfigure with no enclosing git repo anywhere,
the same line in configure will end up as this:
After configuring, src/versioninfo.rc will now contain
"FILEVERSION 1,7,8,", which results in syntax errors.

As long as an enclosing git repo is available somewhere (if
the surrounding vlc tree contains a .git directory), this isn't
an issue though.
 contrib/src/gcrypt/rules.mak | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/contrib/src/gcrypt/rules.mak b/contrib/src/gcrypt/rules.mak
index eff8041..f912b90 100644
--- a/contrib/src/gcrypt/rules.mak
+++ b/contrib/src/gcrypt/rules.mak
@@ -67,6 +67,9 @@ endif
 .gcrypt: gcrypt
+	# Reconfiguring this requires a git repo to be available, to
+	# successfully produce a nonempty mym4_revision_dec.
+	git init && git commit --allow-empty -m "dummy commit"
 	cd $< && $(MAKE) install

More information about the vlc-devel mailing list