[vlc-devel] [PATCH 1/2] configure: Specify a build ID when building with breakpad on windows

[Hugo Beauzée-Luyssen]

On Thu, Dec 21, 2017, at 11:25 AM, Rémi Denis-Courmont wrote:
> Le 21 décembre 2017 12:11:43 GMT+02:00, "Hugo Beauzée-Luyssen" 
> <hugo at beauzee.fr> a écrit :
> >---
> > configure.ac | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> >diff --git a/configure.ac b/configure.ac
> >index 085e432ee9..2a6fd69d74 100644
> >--- a/configure.ac
> >+++ b/configure.ac
> >@@ -3845,7 +3845,9 @@ AS_IF([test "$with_breakpad" != "no"], [
> >       AC_MSG_RESULT([yes])
> >     ])
> >   ],[
> >-    PKG_CHECK_MODULES([BREAKPAD], [breakpad-client],, [
> >+    PKG_CHECK_MODULES([BREAKPAD], [breakpad-client], [
> >+      LDFLAGS="${LDFLAGS} -Wl,--build-id"
> >+    ], [
> >       wiht_breakpad="no"
> >       AC_MSG_WARN(["Breakpad not found"])
> >     ])
> >-- 
> >2.11.0
> >
> >_______________________________________________
> >vlc-devel mailing list
> >To unsubscribe or modify your subscription options:
> >https://mailman.videolan.org/listinfo/vlc-devel
> 
> Fine with me but isn't that an ELF-specific feature?

AFAIK COFF is handled starting from binutils 2.25
https://sourceware.org/ml/binutils/2014-01/msg00296.html

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr