[vlc-devel] [PATCH] Rawaud: mark the rawaud options as safe

[Rémi Denis-Courmont]

Le perjantaina 10. helmikuuta 2017, 13.55.58 EET Jean-Baptiste Kempf a écrit :
> --
> Well, are they?
> I'm surprised they are not safe yet, but it could be too dangerous.
> 
> Opinions?

FOURCC seems safe since it is validated explicitly in Open().

The other ones, I haven´t checked if they are validated in the decoder or 
somewhere else.

> ---
>  modules/demux/rawaud.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/modules/demux/rawaud.c b/modules/demux/rawaud.c
> index ef003fae7b..d05f6314d4 100644
> --- a/modules/demux/rawaud.c
> +++ b/modules/demux/rawaud.c
> @@ -68,9 +68,12 @@ vlc_module_begin();
>      set_callbacks( Open, Close );
>      add_shortcut( "rawaud" );
>      add_integer( "rawaud-channels", 2, CHANNELS_TEXT, CHANNELS_LONGTEXT,
> false ); +        change_safe()
>      add_integer( "rawaud-samplerate", 48000, SAMPLERATE_TEXT,
> SAMPLERATE_LONGTEXT, false ); +        change_safe()
>      add_string( "rawaud-fourcc", FOURCC_DEFAULT,
>                  FOURCC_TEXT, FOURCC_LONGTEXT, false );
> +        change_safe()
>      add_string( "rawaud-lang", "eng", LANG_TEXT, LANG_LONGTEXT, false);
>  vlc_module_end();


-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/