[vlc-devel] [PATCH] core: WINAPI should be set on the pointer

Steve Lhomme robux4 at videolabs.io
Tue Feb 14 13:25:56 CET 2017


We'll be consistent with all the WINAPI function pointers throughout the code.
---
 bin/winvlc.c       | 2 +-
 src/text/url.c     | 2 +-
 src/win32/plugin.c | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/bin/winvlc.c b/bin/winvlc.c
index dfe8878aeb..05cbe750ae 100644
--- a/bin/winvlc.c
+++ b/bin/winvlc.c
@@ -68,7 +68,7 @@ static BOOL SetDefaultDllDirectories_(DWORD flags)
     if (h == NULL)
         return FALSE;
 
-    BOOL WINAPI (*SetDefaultDllDirectoriesReal)(DWORD);
+    BOOL (WINAPI * SetDefaultDllDirectoriesReal)(DWORD);
 
     SetDefaultDllDirectoriesReal = GetProcAddress(h,
                                                   "SetDefaultDllDirectories");
diff --git a/src/text/url.c b/src/text/url.c
index 4430dba612..1b602b599e 100644
--- a/src/text/url.c
+++ b/src/text/url.c
@@ -844,7 +844,7 @@ static int IdnToAscii(DWORD flags, LPCWSTR str, int len, LPWSTR buf, int size)
         return 0;
     }
 
-    int WINAPI (*IdnToAsciiReal)(DWORD, LPCWSTR, int, LPWSTR, int);
+    int (WINAPI *IdnToAsciiReal)(DWORD, LPCWSTR, int, LPWSTR, int);
     int ret = 0;
 
     IdnToAsciiReal = GetProcAddress(h, "IdnToAscii");
diff --git a/src/win32/plugin.c b/src/win32/plugin.c
index e1a37ae3d2..1a65521fca 100644
--- a/src/win32/plugin.c
+++ b/src/win32/plugin.c
@@ -43,7 +43,7 @@ static BOOL WINAPI SetThreadErrorModeFallback(DWORD mode, DWORD *oldmode)
     if (unlikely(h == NULL))
         return FALSE;
 
-    BOOL WINAPI (*SetThreadErrorModeReal)(DWORD, DWORD *);
+    BOOL (WINAPI *SetThreadErrorModeReal)(DWORD, DWORD *);
 
     SetThreadErrorModeReal = GetProcAddress(h, "SetThreadErrorMode");
     if (SetThreadErrorModeReal != NULL)
@@ -53,7 +53,7 @@ static BOOL WINAPI SetThreadErrorModeFallback(DWORD mode, DWORD *oldmode)
     /* As per libvlc_new() documentation, the calling process is responsible
      * for setting a proper error mode on Windows 2008 and earlier versions.
      * This is only a sanity check. */
-    UINT WINAPI (*GetErrorModeReal)(void);
+    UINT (WINAPI *GetErrorModeReal)(void);
     DWORD curmode = 0;
 
     GetErrorModeReal = (void *)GetProcAddress(h, "GetErrorMode");
-- 
2.11.0



More information about the vlc-devel mailing list