[vlc-devel] [PATCH] configure: use the protoc from the contribs if the one from tools is not available

[Rémi Denis-Courmont]

Le tiistaina 14. helmikuuta 2017, 13.32.30 EET Steve Lhomme a écrit :
> This is similar to what is done with luac.exe.
> ---
>  configure.ac | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index b9f199d2ec..a16ba18907 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -442,6 +442,10 @@ AS_IF([test -n "${CONTRIB_DIR}"], [
>      ])
>    ])
> 
> +  AS_IF([test -x "${CONTRIB_DIR}/bin/protoc${BUILDEXEEXT}"], [
> +    PROTOC="${CONTRIB_DIR}/bin/protoc${BUILDEXEEXT}"
> +  ])

This does not make sense. That directory contains binaries for the host 
system, not the build system.

> +
>    AS_IF([test "${SYS}" = "darwin"], [
>      export LD_LIBRARY_PATH="${CONTRIB_DIR}/lib:$LD_LIBRARY_PATH"
>      export DYLD_LIBRARY_PATH="${CONTRIB_DIR}/lib:$DYLD_LIBRARY_PATH"


-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/