[vlc-devel] [PATCH] configure: use the protoc from the contribs if the one from tools is not available

[Rémi Denis-Courmont]

Le tiistaina 14. helmikuuta 2017, 21.53.39 EET Steve Lhomme a écrit :
> On Tue, Feb 14, 2017 at 6:15 PM, Rémi Denis-Courmont <remi at remlab.net> 
wrote:
> > Le tiistaina 14. helmikuuta 2017, 13.32.30 EET Steve Lhomme a écrit :
> >> This is similar to what is done with luac.exe.
> >> ---
> >> 
> >>  configure.ac | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >> 
> >> diff --git a/configure.ac b/configure.ac
> >> index b9f199d2ec..a16ba18907 100644
> >> --- a/configure.ac
> >> +++ b/configure.ac
> >> @@ -442,6 +442,10 @@ AS_IF([test -n "${CONTRIB_DIR}"], [
> >> 
> >>      ])
> >>    
> >>    ])
> >> 
> >> +  AS_IF([test -x "${CONTRIB_DIR}/bin/protoc${BUILDEXEEXT}"], [
> >> +    PROTOC="${CONTRIB_DIR}/bin/protoc${BUILDEXEEXT}"
> >> +  ])
> > 
> > This does not make sense. That directory contains binaries for the host
> > system, not the build system.
> 
> So let's remove that nonsense for luac and only use the tools one.

I don´t think it´s fair to call old code for backward compatibility 
"nonsense". And it is clearly flagged as such:

    dnl Old contribs mixed cross-tools and cross-compiled executables
    AS_IF([test -x "${CONTRIB_DIR}/bin/luac${BUILDEXEEXT}"], [
      LUAC="${CONTRIB_DIR}/bin/luac${BUILDEXEEXT}"
    ])

(Though I don´t really care if those four lines are removed.)

Adding new code like that is what´s nonsense.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/