[vlc-devel] [PATCH 1/8] stream_extractor: split joint capability into two
remi at remlab.net
Sat Feb 18 08:43:54 CET 2017
Le perjantaina 17. helmikuuta 2017, 20.39.30 EET Filip Roséen a écrit :
> Hi Rémi,
> On 2017-02-17 20:13, Rémi Denis-Courmont wrote:
> > Le torstaina 16. helmikuuta 2017, 22.44.11 EET Filip Roséen a écrit :
> > > These changes splits the functionality for a stream-extractor into two
> > > different objects, one being a stream_extractor_t (used to extract
> > > data for an entity within a stream based on an identifier), and the
> > > other, stream_directory_t, is to list entities within a stream.
> > >
> > > Summary of changes:
> > > - update and refine documentation belonging to stream-extractors
> > > - stream_extractor_t is now stream_extractor_t and stream_directory_t
> > To me, that looks better than the union.
> > Although AFAICT, stream_directory_t is a "subset" of stream_t, and
> > stream_extractor_t would also be a subset except for the identifier. Then
> > you don´t even need new types: you can just define a new pf_activate
> > callback prototype to carry the identifier.
> Yes, and that approach also crossed my mind before implementing it the
> first way, and now the second way; though I considered changes to
> `pf_activate` to be a more intrusive than the path taken.
This has nothing to do with you but just like that, somebody decided that
breaking the build was OK . This is utterly insane.
I am so pissed and fed up I cannot be bothered to review any code on my free
time any more.
More information about the vlc-devel