[vlc-devel] [PATCH 1/8] stream_extractor: split joint capability into two

[Filip Roséen]

Hi Rémi,

On 2017-02-18 11:50, Rémi Denis-Courmont wrote:

> Le lauantaina 18. helmikuuta 2017, 10.30.40 EET Filip Roséen a écrit :
>
> > > This is valid but I don´t know why a very few developpers do this. The
> > > defacto standard is qualifier before type.
> > 
> > Not sure what *"defacto standard"* you are referring to,
> 
> It is both de jure standard (ISO C uses const type, and so does POSIX), and de 
> facto (most code and most devs use that order too).

I was not talking about the conventions used in standards issued by
*ISO WG14* and *ISO WG21*, I was referring to usage in the wild (and
"de facto standards" that prohibits/frowns upon *"type cv-qualifier"* vs
*"cv-qualifier type"*.

As this is becoming off-topic, I would be happy to discuss such
preference in a separate discussion (perhaps over IRC as it seems like
a suitable medium).

> > We should spend some time writing up a coding guideline so that we do
> > not have to end up with reviews such as this (where it is quite
> > obvious that things boil down to a personal taste).
> 
> Taste? We do this when it servers some purpose, such as hiding the structure 
> layout in a more private location. Here, it does not.
>
> The reason why we have to many typedef struct a a; is hysterical raisins from 
> vlc_symbols.h era.

No comment.

Adjustments will be made to satisfy the expressed opinions. I will
wait a little before posting an updated patch so that others might
have a chance to ask for other changes (as posting patch after patch
with minor changes are more tedious to review). 

/F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170218/d10fe88a/attachment.html>