[vlc-devel] [PATCH 2/2] demux/mkv: fix ES handling during DEMUX_SET_TITLE

[Filip Roséen]

Hi j-b,

On 2017-02-20 19:05, Jean-Baptiste Kempf wrote:

> Hello,
> 
> On Mon, 20 Feb 2017, at 18:10, Filip Roséen wrote:
> > As part of seeking to a new virtual chapter, we have to destroy the
> > elementary streams that are part of the current one, and then create
> > the streams associated with the seeking-to virtual chapter.
> 
> Doesn't that lose the selected audio and subtitle track?

The way things are handled in the relevant code-path is the same as
when playing an mkv with linked segments normally (back to back).
There is code in-place to remember the previously selected *audio-*
and *subtitle-track* language in order to continue with a matching
track (if available).

See the below links:

 - call to `virtual_segment_c::KeepTrackSelection`:
   - http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/mkv/virtual_segment.cpp;h=6d1863b9ac449f6ed6a4ad845c2ee321a6551bb5;hb=HEAD#l542

 - implementation of `virtual_segment_c::KeepTrackSelection`:
   - http://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/mkv/virtual_segment.cpp;h=6d1863b9ac449f6ed6a4ad845c2ee321a6551bb5;hb=HEAD#l689

Best Regards,\
Filip
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170220/c2cb08d9/attachment.html>