[vlc-devel] [RFC] vlc_xml: add copy node function

[Nicolas Bertrand]

On 23/02/2017 23:08, Rémi Denis-Courmont wrote:
>> ---
>>  include/vlc_xml.h         |  7 +++++++
>>  modules/misc/xml/libxml.c | 40 ++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 47 insertions(+)
>>
>> diff --git a/include/vlc_xml.h b/include/vlc_xml.h
>> index 661e76d..fd14ab6 100644
>> --- a/include/vlc_xml.h
>> +++ b/include/vlc_xml.h
>> @@ -75,6 +75,7 @@ struct xml_reader_t
>>
>>      int (*pf_use_dtd) ( xml_reader_t * );
>>      int (*pf_is_empty) ( xml_reader_t * );
>> +    int (*pf_copy_node) ( xml_reader_t *, const char **);
> If there is only one error case (or no need to distinguish errors), then you 
> are better off returning a char * directly.
> 
> And something looks fishy here. How can the result be constant? What´s the 
> life cycle?
> 
Oki, i'll correct all this  by this function proto
char * (*pf_copy_node) ( xml_reader_t *);

thks for the rmks
-- 
Nicolas Bertrand
01 86 95 00 79
www.indecp.org
support technique: technique at indecp.org