[vlc-devel] [PATCH 1/5] gui/qt: extended_panels: declare helper-functions as static

Filip Roséen filip at atch.se
Sat Feb 25 07:31:41 CET 2017


These functions are only used within the translation-unit in question,
and as such it does not make sense for them to have external linkage.
---
 modules/gui/qt/components/extended_panels.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/gui/qt/components/extended_panels.cpp b/modules/gui/qt/components/extended_panels.cpp
index 52325d8502..4a3d7d3ade 100644
--- a/modules/gui/qt/components/extended_panels.cpp
+++ b/modules/gui/qt/components/extended_panels.cpp
@@ -56,12 +56,12 @@ static char *ChangeFiltersString( struct intf_thread_t *p_intf, const char *psz_
 static void ChangeAFiltersString( struct intf_thread_t *p_intf, const char *psz_name, bool b_add );
 static void ChangeVFiltersString( struct intf_thread_t *p_intf, const char *psz_name, bool b_add );
 
-const QString ModuleFromWidgetName( QObject *obj )
+static const QString ModuleFromWidgetName( QObject *obj )
 {
     return obj->objectName().replace( "Enable","" );
 }
 
-QString OptionFromWidgetName( QObject *obj )
+static QString OptionFromWidgetName( QObject *obj )
 {
     /* Gruik ? ... nah */
     QString option = obj->objectName().replace( "Slider", "" )
-- 
2.11.1



More information about the vlc-devel mailing list