[vlc-devel] [PATCH 3/7] gui/qt: info_panels: remove comments containing legacy code

Filip Roséen filip at atch.se
Sat Feb 25 07:38:58 CET 2017


These sections were commented out as part of 86a25b2c1b9 and
fe3beadd6b0 (2007-09), and has been unchanged ever since.

--

 - http://git.videolan.org/?p=vlc.git;a=commit;h=86a25b2c1b9
 - http://git.videolan.org/?p=vlc.git;a=commit;h=fe3beadd6b0
---
 modules/gui/qt/components/info_panels.cpp | 9 ---------
 modules/gui/qt/components/info_panels.hpp | 1 -
 2 files changed, 10 deletions(-)

diff --git a/modules/gui/qt/components/info_panels.cpp b/modules/gui/qt/components/info_panels.cpp
index 75032750a3..c8825c179e 100644
--- a/modules/gui/qt/components/info_panels.cpp
+++ b/modules/gui/qt/components/info_panels.cpp
@@ -121,13 +121,6 @@ MetaPanel::MetaPanel( QWidget *parent,
     metaLayout->addWidget( seqtot_text, line, 9, 1, 1 );
     line++;
 
-    /* Rating - on the same line */
-    /*
-    metaLayout->addWidget( new QLabel( qtr( VLC_META_RATING ) ), line, 4, 1, 2 );
-    rating_text = new QSpinBox; setSpinBounds( rating_text );
-    metaLayout->addWidget( rating_text, line, 6, 1, 1 );
-    */
-
     /* Now Playing - Useful for live feeds (HTTP, DVB, ETC...) */
     ADD_META( VLC_META_NOW_PLAYING, nowplaying_text, 0, 7 );
     nowplaying_text->setReadOnly( true ); line--;
@@ -181,7 +174,6 @@ MetaPanel::MetaPanel( QWidget *parent,
 
     CONNECT( date_text, textEdited( QString ), this, enterEditMode() );
 //    CONNECT( THEMIM->getIM(), artChanged( QString ), this, enterEditMode() );
-/*    CONNECT( rating_text, valueChanged( QString ), this, enterEditMode( QString ) );*/
 
     /* We are not yet in Edit Mode */
     b_inEditMode = false;
@@ -248,7 +240,6 @@ void MetaPanel::update( input_item_t *p_item )
     UPDATE_META( TrackNum, seqnum_text );
     UPDATE_META( TrackTotal, seqtot_text );
 //    UPDATE_META( Setting, setting_text );
-//    UPDATE_META_INT( Rating, rating_text );
 
     /* Now Playing || ES Now Playing */
     psz_meta = input_item_GetNowPlayingFb( p_item );
diff --git a/modules/gui/qt/components/info_panels.hpp b/modules/gui/qt/components/info_panels.hpp
index 6f984daf3a..189e75dcf2 100644
--- a/modules/gui/qt/components/info_panels.hpp
+++ b/modules/gui/qt/components/info_panels.hpp
@@ -69,7 +69,6 @@ private:
     QLineEdit *seqtot_text;
 
     QTextEdit *description_text;
-//    QSpinBox *rating_text;
     QLineEdit *date_text;
 //    QLineEdit *setting_text;
     QLineEdit *language_text;
-- 
2.11.1



More information about the vlc-devel mailing list