[vlc-devel] [vlc-commits] strings: use vlc_memstream in vlc_xml_encode()

[Rémi Denis-Courmont]

Le lauantaina 25. helmikuuta 2017, 15.05.21 EET Filip Roséen a écrit :
> Hi Rémi,
> 
> On 2017-02-25 15:27, Rémi Denis-Courmont wrote:
> > > > The explanation is factual. One does not get to agree or disagree with
> > > > it.
> > > 
> > > Ok, now I completely am out of words. I thought this was a discussion,
> > > not a place where "factual" statements expressed by one party are the
> > > only truth, and opinions of the other party does not matter.
> > 
> > - It is a fact, not an opinion, that ignoring an error here is safe.
> > - It is a fact, not an opinion, that an error cannot happen with one
> > back-end. - It is a fact, not an opinion, that an error is practically
> > impossible to trigger with the other back-end.
> 
> Just as practically impossible as memory-allocation failures.

Are you trolling or what? Ignoring memory allocation failures leads to 
undefined behaviour; it is clearly not inconsequential.

(And some of them are easy to trigger with fuzzers.)

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/