[vlc-devel] [PATCH 1/8] ES: add a property to audio_format_t for Ambisonics support

[Jean-Baptiste Kempf]

Hello,

On Fri, 24 Feb 2017, at 18:51, Rémi Denis-Courmont wrote:
> > +    audio_channel_type_t channel_type;
> > +
> >      /* Optional - for A/52, SPDIF and DTS types : */
> >      /* Bytes used by one compressed frame, depends on bitrate. */
> >      unsigned int i_bytes_per_frame;
> 
> Frankly, I don´t recommend adding a new member, especially not an
> enumeration, 
> as dealing with it throughout the code base will be painstakingly
> tedious. I 
> suspect that the rest of the patch series only scratches the surface.
> 
> If it were possible, I would just define new formats, as there is still
> plenty 
> of space left in the 32-bits number space. But I suppose that you want 
> orthogonality to the sample format; then I admittedly don´t have any
> better 
> idea.

And don't forget that this is the first step, since we will then get
AUDIO_3D_OBJECT too at some point...

And yes, we need orthogonality with the sample format.

-- 
Jean-Baptiste Kempf -  President
+33 672 704 734