[vlc-devel] [PATCH 3/3] demux/mkv: use appropriate helper for A_ALAC

Filip Roséen filip at atch.se
Sat Feb 25 20:21:55 CET 2017


The correct helper-function is named fill_extra_data_alac, and not
fill_extra_data. The errournous usage seems to have been introduced during the
big refactoring of the demuxer.

--

The implication of not using the correct function is of course that playback
will misbehave (most likely fail completely for the track in question).

refs #16620

---
 modules/demux/mkv/matroska_segment_parse.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/demux/mkv/matroska_segment_parse.cpp b/modules/demux/mkv/matroska_segment_parse.cpp
index 0f96ffa123..30aa550473 100644
--- a/modules/demux/mkv/matroska_segment_parse.cpp
+++ b/modules/demux/mkv/matroska_segment_parse.cpp
@@ -1640,7 +1640,7 @@ int32_t matroska_segment_c::TrackInit( mkv_track_t * p_tk )
         }
         S_CASE("A_ALAC") {
             vars.p_tk->fmt.i_codec = VLC_CODEC_ALAC;
-            fill_extra_data( vars.p_tk, 0);
+            fill_extra_data_alac( vars.p_tk );
         }
         S_CASE("A_WAVPACK4") {
             vars.p_tk->fmt.i_codec = VLC_CODEC_WAVPACK;
-- 
2.11.1



More information about the vlc-devel mailing list