[vlc-devel] [PATCH 5/6] vlc_common: introduce macro VLC_ATTR
filip at atch.se
Sun Feb 26 21:04:12 CET 2017
On 2017-02-26 21:55, Rémi Denis-Courmont wrote:
> Le sunnuntaina 26. helmikuuta 2017, 20.50.57 EET Filip Roséen a écrit :
> > Hi Rémi,
> > On 2017-02-26 21:28, Rémi Denis-Courmont wrote:
> > > Nack.
> > Care to elaborate the above statement; exactly what is it that you are
> > *"nacking"*?
> I am nacking the entire patch. It is pure luck if it does not break the test
> suite (I have not checked).
As already stated, given that you nacked an obvious dependency it is
quite clear that you are not a fan of what follows.
Regarding the test suite I do not see how the patches in question
changes any behavior other than not making use of attributes when the
compiler either rejects or will ignore them completely (at least that
is the underlying idea).
I am sorry if I missed something that really does change the behavior,
other than what was previously stated by you in the message linked
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel