[vlc-devel] [PATCH 3/6] vout: check pools leaks

[Thomas Guillem]

On Mon, Jan 9, 2017, at 15:47, Thomas Guillem wrote:
> 
> 
> On Mon, Jan 9, 2017, at 12:14, Rémi Denis-Courmont wrote:
> > Le jeudi 5 janvier 2017, 15:52:47 Rémi Denis-Courmont a écrit :
> > > Le jeudi 5 janvier 2017, 14:37:41 Thomas Guillem a écrit :
> > > > Show an error message and assert if filters, decoders or vout displays
> > > > leak
> > > > pictures.
> > > 
> > > That does not seem right. Last I checked, the picture pool can be deleted
> > > before the pictures it contains.
> > 
> > There is even a unit test case to validate that.
> 
> I read the test case. I agree without: you can call
> picture_pool_Release() before deleting the pictures it contains. But the
> picture_pool will be de-allocated when you release the last picture (so
> when the pool ref count decrease to 0).
> 
> I think this patch is still valid, because I check for leaks after all
> decoder/vout/filters modules are unloaded (they should have released all
> their pictures).

I'll propose a new set of patches, with split patches and more comments.

> 
> > 
> > -- 
> > Rémi Denis-Courmont
> > http://www.remlab.net/
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel