[vlc-devel] [vlc-commits] demux: ttml: replace timings on output

[Francois Cartegnie]

Le 12/01/2017 à 16:18, Filip Roséen a écrit :
> The above looks very very odd. Given that it looks like you are trying
> to extract hours, minutes, and seconds, something like the below would
> be correct:
> 
>     h = i_time / 3600;
>     m = i_time % 3600 / 60;
>     s = i_time % 60;
> 
> It is also worth noting that I personally feel that readability is
> harmed when variable declarations are separated from their
> initialization for no apparent reason.

I haven't really tested for over second timings. But min seems
incorrect, yes.


>> +                /* remove */
>> +                continue;
>> +            }
> 
> For all cases where `strcmp` is used above, `strcasecmp` might make
> more sense (given that the case of the attributes are not strictly
> limited to lower-case, afaik)?

Since when ? That's not HTML 1.0 crap.
XML is case sensitive. We already fail on namespaces, let's not add more
broken matches.

Francois