[vlc-devel] [PATCH 0/8] rework archive extraction

Filip Roséen filip at atch.se
Thu Jan 12 19:21:15 CET 2017


I hope the commit messages are descriptive enough to speak for
themselves, but in short:

 - implement a stream-extractor using libarchive
 - rework skins2 to use new stream-extractor functionality
 - remove legacy archive handlers

As can be seen in this summary, a lot of code has been removed; I have
tried to make sure that there are not any regressions because of the
replacement, but a few extra eyes (and tester) are more than welcome
to verify that things are behaving better (and not worse) than before.


One could view a compressed archive as a box, so.. here's one:

                      ____.----.
            ____.----'          \
            \                    \
             \                    \
              \                    \
               \          ____.----'`--.__
                \___.----'          |     `--.____
               /`-._                |       __.-' \
              /     `-._            ___.---'       \
             /          `-.____.---'                \
            /            / | \                       \
           /            /  |  \                   _.--'
           `-.         /   |   \            __.--'
              `-._    /    |    \     __.--'     |
                | `-./     |     \_.-'           |
                |          |                     |
                |          |                     |
                |          |                     |
                |          |                     |
                |          |                     |   VK
                |          |                     |
         _______|          |                     |_______________
                `-.        |                  _.-'
                   `-.     |           __..--'
                      `-.  |      __.-'
                         `-|__.--'
    src: http://www.chris.com/ascii/index.php?art=objects/boxes


Filip Roséen (8):
  contrib: bump libarchive version
  modules/stream_extractor: added libarchive extractor
  gui/skins2: add ThemeLoader::unarchive
  gui/skins2: use ThemeLoader::unarchive
  gui/skins2: remove legacy archive dependencies
  modules/access: remove legacy rar access
  modules/access: removal of legacy archive access/filter
  access: remove legacy zip accessor/stream

 NEWS                                    |    1 +
 configure.ac                            |    8 +-
 contrib/src/libarchive/SHA512SUMS       |    2 +-
 contrib/src/libarchive/rules.mak        |    6 +-
 modules/access/Makefile.am              |   29 -
 modules/access/archive/access.c         |  440 ---------
 modules/access/archive/archive.c        |  111 ---
 modules/access/archive/archive.h        |   39 -
 modules/access/archive/stream.c         |  226 -----
 modules/access/rar/access.c             |  247 -----
 modules/access/rar/module.c             |   39 -
 modules/access/rar/rar.c                |  409 --------
 modules/access/rar/rar.h                |   48 -
 modules/access/rar/stream.c             |  162 ----
 modules/access/zip/unzip/crypt.h        |  133 ---
 modules/access/zip/unzip/ioapi.c        |  181 ----
 modules/access/zip/unzip/ioapi.h        |   75 --
 modules/access/zip/unzip/unzip.c        | 1602 -------------------------------
 modules/access/zip/unzip/unzip.h        |  354 -------
 modules/access/zip/zip.h                |   75 --
 modules/access/zip/zipaccess.c          |  408 --------
 modules/access/zip/zipstream.c          |  845 ----------------
 modules/gui/skins2/src/theme_loader.cpp |  739 +++-----------
 modules/gui/skins2/src/theme_loader.hpp |   30 +-
 modules/stream_extractor/Makefile.am    |    8 +
 modules/stream_extractor/archive.c      |  686 +++++++++++++
 po/POTFILES.in                          |    1 +
 27 files changed, 860 insertions(+), 6044 deletions(-)
 delete mode 100644 modules/access/archive/access.c
 delete mode 100644 modules/access/archive/archive.c
 delete mode 100644 modules/access/archive/archive.h
 delete mode 100644 modules/access/archive/stream.c
 delete mode 100644 modules/access/rar/access.c
 delete mode 100644 modules/access/rar/module.c
 delete mode 100644 modules/access/rar/rar.c
 delete mode 100644 modules/access/rar/rar.h
 delete mode 100644 modules/access/rar/stream.c
 delete mode 100644 modules/access/zip/unzip/crypt.h
 delete mode 100644 modules/access/zip/unzip/ioapi.c
 delete mode 100644 modules/access/zip/unzip/ioapi.h
 delete mode 100644 modules/access/zip/unzip/unzip.c
 delete mode 100644 modules/access/zip/unzip/unzip.h
 delete mode 100644 modules/access/zip/zip.h
 delete mode 100644 modules/access/zip/zipaccess.c
 delete mode 100644 modules/access/zip/zipstream.c
 create mode 100644 modules/stream_extractor/archive.c

-- 
2.11.0



More information about the vlc-devel mailing list