[vlc-devel] [PATCH 5/7] vout: reset pause state from ThreadReinit()

[Thomas Guillem]

My patch is wrong, the pause should be set on top of the ThreadReinit()
function since it can return VLC_SUCCESS at the beginning (if video fmt
are equals).

ThreadInit() set the pause state to false, so the vout is always
initialized not paused. I really think we should do the same for
ThreadReinit().

On Mon, Jan 16, 2017, at 09:38, Thomas Guillem wrote:
> 
> 
> On Sun, Jan 15, 2017, at 14:38, Rémi Denis-Courmont wrote:
> > Le mercredi 11 janvier 2017, 09:13:12 Thomas Guillem a écrit :
> > > ---
> > >  src/video_output/video_output.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/src/video_output/video_output.c
> > > b/src/video_output/video_output.c index ad668ebb86..258291422d 100644
> > > --- a/src/video_output/video_output.c
> > > +++ b/src/video_output/video_output.c
> > > @@ -1536,6 +1536,8 @@ static int ThreadReinit(vout_thread_t *vout,
> > >      vout_display_state_t state;
> > >      memset(&state, 0, sizeof(state));
> > > 
> > > +    vout->p->pause.is_on = false;
> > > +    vout->p->pause.date  = VLC_TS_INVALID;
> > >      ThreadStop(vout, &state);
> > > 
> > >      if (!state.cfg.is_fullscreen) {
> > 
> > Sounds like a bug in decoder code?
> 
> See 1af6b527cbd
> 
> I think that the vout should be reinit paused or unpaused.
> I'll check if there is a proper fix.
> 
> > 
> > -- 
> > Rémi Denis-Courmont
> > http://www.remlab.net/
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel