[vlc-devel] [PATCH 02/10] converter/tospdif: rename write_16

[Jean-Baptiste Kempf]

LGTM

On Wed, 18 Jan 2017, at 09:20, Thomas Guillem wrote:
> Rename it to set_16 since this function doesn't increment the offset.
> ---
>  modules/audio_filter/converter/tospdif.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/modules/audio_filter/converter/tospdif.c
> b/modules/audio_filter/converter/tospdif.c
> index a5e50651ce..f8a8a25f2b 100644
> --- a/modules/audio_filter/converter/tospdif.c
> +++ b/modules/audio_filter/converter/tospdif.c
> @@ -99,7 +99,7 @@ static bool is_big_endian( filter_t *p_filter, block_t
> *p_in_buf )
>      }
>  }
>  
> -static inline void write_16( filter_t *p_filter, void *p_buf, uint16_t
> i_val )
> +static void set_16( filter_t *p_filter, void *p_buf, uint16_t i_val )
>  {
>      if( p_filter->fmt_out.audio.i_format == VLC_CODEC_SPDIFB )
>          SetWBE( p_buf, i_val );
> @@ -142,7 +142,7 @@ static void write_data( filter_t *p_filter, const
> void *p_buf, size_t i_size,
>      {
>          assert( p_sys->p_out_buf->i_buffer - p_sys->i_out_offset >= 2 );
>          p_out += ( i_size & ~1 );
> -        write_16( p_filter, p_out, p_in[i_size - 1] << 8 );
> +        set_16( p_filter, p_out, p_in[i_size - 1] << 8 );
>          p_sys->i_out_offset += 2;
>      }
>  }
> @@ -186,11 +186,11 @@ static void write_finalize( filter_t *p_filter,
> uint16_t i_data_type,
>          assert( p_sys->i_out_offset > SPDIF_HEADER_SIZE );
>          assert( i_length_mul == 1 || i_length_mul == 8 );
>  
> -        write_16( p_filter, &p_out[0], 0xf872 ); /* syncword 1 */
> -        write_16( p_filter, &p_out[2], 0x4e1f ); /* syncword 2 */
> -        write_16( p_filter, &p_out[4], i_data_type ); /* data type */
> +        set_16( p_filter, &p_out[0], 0xf872 ); /* syncword 1 */
> +        set_16( p_filter, &p_out[2], 0x4e1f ); /* syncword 2 */
> +        set_16( p_filter, &p_out[4], i_data_type ); /* data type */
>          /* length in bits or bytes */
> -        write_16( p_filter, &p_out[6],
> +        set_16( p_filter, &p_out[6],
>                    ( p_sys->i_out_offset - SPDIF_HEADER_SIZE ) *
>                    i_length_mul );
>      }
>  
> -- 
> 2.11.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


-- 
Jean-Baptiste Kempf -  President
+33 672 704 734