[vlc-devel] [PATCH 1/3] input/decoder: add decoder_DecodeAgain

Rémi Denis-Courmont remi at remlab.net
Sat Jan 21 02:38:12 CET 2017

Le vendredi 20 janvier 2017, 17:06:08 Thomas Guillem a écrit :
> This new function can be used to save an input block when a decoder module
> is requesting a restart.
> This can solve the issue when the first input block is lost after a hardware
> decoder requested a restart while decoding this block.
> This can't solve the issue when more than one input blocks are lost after a
> hardware decoder requested a restart asynchronously (less common case).

No. It only works if the decoder processed the input blocks synchronously (to 
the extent that the error occurs before pf_decode returns), and fails on the 
first block, and the decoder code is not changed in further ways.

Specifically if error is asynchronous, then this will sometime work, and 
sometimes corrupt the bitstream - making things worse rather than better.

So I think this is a very bad idea.

Rémi Denis-Courmont

More information about the vlc-devel mailing list