[vlc-devel] [PATCH] vpx: decoder: Set i_sar_num and i_sar_den

[Tristan Matthews]

Hi,

On Mon, Jan 23, 2017 at 8:38 PM, Andrew Clayton
<andrew at digital-domain.net> wrote:
> On Mon, 23 Jan 2017 20:23:14 -0500
> Tristan Matthews <tmatth at videolan.org> wrote:
>
>> > +    dec->fmt_out.video.i_sar_num = dec->fmt_in.video.i_sar_num;
>> > +    dec->fmt_out.video.i_sar_den = dec->fmt_in.video.i_sar_den;
>>
>> I think you want to check that dec->fmt_in.video.i_sar_{num, den} are
>> greater than 0 before setting these.
>
> Ah, I should have mentioned that in the commit message. If they are 0
> at some point they are treated as 1.
>
> But yeah I can do that check. Thanks for the review!
>
> I take it it only makes sense to set them if they are *both* > 0?

I believe so, yes.

Best,
Tristan