[vlc-devel] [vlc-commits] Qt: add stereowiden filter

[Hugo Beauzée-Luyssen]

On 01/24/2017 12:01 PM, Francois Cartegnie wrote:
> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Tue Jan 24 11:50:08 2017 +0100| [3d8091e5c50fb8443ad19dca940cbbf52bbefcd2] | committer: Francois Cartegnie
>
> Qt: add stereowiden filter
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3d8091e5c50fb8443ad19dca940cbbf52bbefcd2
> ---
>
>  modules/gui/qt/components/extended_panels.cpp | 19 +++++++++++++++++++
>  modules/gui/qt/components/extended_panels.hpp |  8 ++++++++
>  modules/gui/qt/dialogs/extended.cpp           |  4 ++++
>  3 files changed, 31 insertions(+)
>
> diff --git a/modules/gui/qt/components/extended_panels.cpp b/modules/gui/qt/components/extended_panels.cpp
> index c44bed5..52325d8 100644
> --- a/modules/gui/qt/components/extended_panels.cpp
> +++ b/modules/gui/qt/components/extended_panels.cpp
> @@ -1408,6 +1408,25 @@ Spatializer::Spatializer( intf_thread_t *p_intf, QWidget *parent )
>      build();
>  }
>
> +/**********************************************************************
> + * Spatializer
> + **********************************************************************/
> +
> +StereoWidener::StereoWidener( intf_thread_t *p_intf, QWidget *parent )
> +    : AudioFilterControlWidget( p_intf, parent, "stereo_widen" )
> +{
> +    i_smallfont = -1;
> +    const FilterSliderData::slider_data_t a[4] =
> +    {
> +        { "stereowiden-delay",     N_("Delay time"),    "ms", 1.0, 100,  20, 1.0, 1.0 },
> +        { "stereowiden-feedback",  N_("Feedback gain"), "%",  0.0, 0.9, 0.3, 0.1, 1.0 },
> +        { "stereowiden-crossfeed", N_("Crossfeed"),     "%",  0.0, 0.8, 0.3, 0.1, 1.0 },
> +        { "stereowiden-dry-mix",   N_("Dry mix"),       "%",  0.0, 1.0, 0.8, 0.1, 1.0 },
> +    };
> +    for( int i=0; i<4 ;i++ ) controls.append( a[i] );
> +    build();
> +}
> +
>  #include <QToolButton>
>  #include <QGridLayout>
>
> diff --git a/modules/gui/qt/components/extended_panels.hpp b/modules/gui/qt/components/extended_panels.hpp
> index 0c67554..a941332 100644
> --- a/modules/gui/qt/components/extended_panels.hpp
> +++ b/modules/gui/qt/components/extended_panels.hpp
> @@ -204,6 +204,14 @@ public:
>      Spatializer( intf_thread_t *, QWidget * );
>  };
>
> +class StereoWidener: public AudioFilterControlWidget
> +{
> +    Q_OBJECT

I don't think you need to declare this a Q_OBJECT since there are no 
signal/slot

> +
> +public:
> +    StereoWidener( intf_thread_t *, QWidget * );
> +};
> +
>  class SyncWidget : public QWidget
>  {
>      Q_OBJECT
> diff --git a/modules/gui/qt/dialogs/extended.cpp b/modules/gui/qt/dialogs/extended.cpp
> index 05750cb..6f6a9fa 100644
> --- a/modules/gui/qt/dialogs/extended.cpp
> +++ b/modules/gui/qt/dialogs/extended.cpp
> @@ -70,6 +70,10 @@ ExtendedDialog::ExtendedDialog( intf_thread_t *_p_intf )
>      audioTab->addTab( spatial, qtr( "Spatializer" ) );
>      audioLayout->addWidget( audioTab );
>
> +    StereoWidener *stereowiden = new StereoWidener( p_intf, audioTab );
> +    audioTab->addTab( stereowiden, qtr( "Stereo Widener" ) );
> +    audioLayout->addWidget( audioTab );
> +
>      mainTabW->insertTab( AUDIO_TAB, audioWidget, qtr( "Audio Effects" ) );
>
>      /* Video Effects */
>
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits
>