[vlc-devel] [PATCH] taglib: Add some debug logging

[Rémi Denis-Courmont]

On January 26, 2017 5:32:41 PM GMT+02:00, Marvin Scholz <epirat07 at gmail.com> wrote:
>---
> modules/meta_engine/taglib.cpp | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/modules/meta_engine/taglib.cpp
>b/modules/meta_engine/taglib.cpp
>index 6d051ba..3a986c6 100644
>--- a/modules/meta_engine/taglib.cpp
>+++ b/modules/meta_engine/taglib.cpp
>@@ -285,6 +285,7 @@ static int ExtractCoupleNumberValues( vlc_meta_t*
>p_meta, const char *psz_value,
>  */
>static void ReadMetaFromAPE( APE::Tag* tag, demux_meta_t* p_demux_meta,
>vlc_meta_t* p_meta )
> {
>+    msg_Dbg(p_demux_meta, "Reading Metadata from APE");
>     APE::ItemListMap fields ( tag->itemListMap() );
>     APE::ItemListMap::Iterator iter;
> 
>@@ -393,7 +394,7 @@ static void ReadMetaFromAPE( APE::Tag* tag,
>demux_meta_t* p_demux_meta, vlc_meta
>  */
>static void ReadMetaFromASF( ASF::Tag* tag, demux_meta_t* p_demux_meta,
>vlc_meta_t* p_meta )
> {
>-
>+    msg_Dbg(p_demux_meta, "Reading Metadata from ASF");
>     ASF::AttributeList list;
>#define SET( keyName, metaName )                                       
>             \
>if( tag->attributeListMap().contains(keyName) )                        
>         \
>@@ -467,6 +468,7 @@ static void ReadMetaFromASF( ASF::Tag* tag,
>demux_meta_t* p_demux_meta, vlc_meta
>  */
>static void ReadMetaFromId3v2( ID3v2::Tag* tag, demux_meta_t*
>p_demux_meta, vlc_meta_t* p_meta )
> {
>+    msg_Dbg(p_demux_meta, "Reading Metadata from Id3v2");
>     // Get the unique file identifier
>     ID3v2::FrameList list = tag->frameListMap()["UFID"];
>     ID3v2::FrameList::Iterator iter;
>@@ -669,6 +671,7 @@ static void ReadMetaFromId3v2( ID3v2::Tag* tag,
>demux_meta_t* p_demux_meta, vlc_
>  */
>static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_meta_t*
>p_demux_meta, vlc_meta_t* p_meta )
> {
>+    msg_Dbg(p_demux_meta, "Reading Metadata from VorbisComment
>(Xiph)");
>     StringList list;
>     bool hasTrackTotal = false;
>#define SET( keyName, metaName )                                       
>       \
>@@ -776,6 +779,7 @@ static void ReadMetaFromXiph( Ogg::XiphComment*
>tag, demux_meta_t* p_demux_meta,
>  */
>static void ReadMetaFromMP4( MP4::Tag* tag, demux_meta_t *p_demux_meta,
>vlc_meta_t* p_meta )
> {
>+    msg_Dbg(p_demux_meta, "Reading Metadata from MP4");
>     MP4::Item list;
>#define SET( keyName, metaName )                                       
>                     \
>if( tag->itemListMap().contains(keyName) )                             
>                 \
>-- 
>2.10.1 (Apple Git-78)
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

Hello,

IMO, those specific debug additions bring no obvious value. At least elaborate the commit message...
-- 
Rémi Denis-Courmont