[vlc-devel] [PATCH] Fixed incorrect backward/forward reference ordering in vaapi deinterlacing

Thomas Guillem thomas at gllm.fr
Tue Jul 4 14:00:04 CEST 2017


> Is that not down to whether you choose to output two frames or not
> though? i.e. you could just have easily as implemented DXVA2 X and Bob
> modes without doubling the frame rate? Or are you saying that DXVA2
> expects to always output two frames for these deinterlace modes and it
> would be wrong to only output single frames (as you had it with your
> original DXVA2 deinterlace check-in).> 
> Don't get me wrong - I personally much prefer it as you've done it, as
> I don't really see why you'd want to deinterlace 1080i input and *not*
> output double the frame rate. But there must be some use-cases I
> haven't thought of.> 
> But the same choice seems to exist for VAAPI - either loop through and
> output two frames each time, or don't. And the suggestion was that the
> existing "Bob" and "x" should continue to output single frames,
> whereas double frames should be reserved for new "Bob2" and "x2"
> variants....which would seem to be inconsistent vs DXVA2, although
> consistent with software.
Hi,

I'm OK to double bob and x for VAAPI and name it "Bob" and "x" (so that
dxva and vaapi behave the same way).If you propose a patch, I'll do some test, but this seems a good idea.

Regards,
Thomas.

> 
>>> I presume it needs to be consistent across modules?
>>> 
>>>>> 
>>>>>> Regards.
>>>>>> _______________________________________________
>>>>>> vlc-devel mailing list
>>>>>> To unsubscribe or modify your subscription options:
>>>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>>> 
>>>>> _______________________________________________
>>>>> vlc-devel mailing list
>>>>> To unsubscribe or modify your subscription options:
>>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>> _______________________________________________
>>>> vlc-devel mailing list
>>>> To unsubscribe or modify your subscription options:
>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170704/f953f1f4/attachment.html>


More information about the vlc-devel mailing list