[vlc-devel] [PATCH] core: call fourcc_gen with the file extension it was created with

[Steve Lhomme]

On Tue, Jul 4, 2017 at 7:02 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le tiistaina 4. heinäkuuta 2017, 17.50.57 EEST Steve Lhomme a écrit :
>> Helps compile with Windows Subsystem for Linux
>
> I can see that helping on Cygwin, but not in an emulated Linux

Yes, that should help too.

> environment...?!

That might have to do with the fact I build with
--build=x86_64-w64-mingw32 --host=x86_64-w64-mingw32 so that it
generates plugins.dat. Which saves me a lot of time when debugging
with (crap) gdb.

It's odd that BUILDEXEEXT is not detected from what BUILDCC outputs
but for now that should do. And anyway all targets using it should be
used in a coherent way.

>> ---
>>  src/Makefile.am | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index c93a4021ee..6b661a655d 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -494,7 +494,7 @@ fourcc_gen$(BUILDEXEEXT): misc/fourcc_gen.c
>> misc/fourcc_list.h ../include/vlc_fo
>>
>>  fourcc_tables.h: fourcc_gen$(BUILDEXEEXT)
>>       $(AM_V_at)rm -f -- $@.tmp
>> -     $(AM_V_GEN)$(builddir)/fourcc_gen > $@.tmp
>> +     $(AM_V_GEN)$(builddir)/fourcc_gen$(BUILDEXEEXT) > $@.tmp
>>       $(AM_V_at)mv -f -- $@.tmp $@
>>
>>  # Unit/regression tests
>
>
> --
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel