[vlc-devel] [PATCH 2/2] mmdevice: handle AUDCLNT_E_ALREADY_INITIALIZED

[Thomas Guillem]

On Wed, Jul 5, 2017, at 19:00, Rémi Denis-Courmont wrote:
> Le keskiviikkona 5. heinäkuuta 2017, 18.39.21 EEST Thomas Guillem a écrit
> :
> > Sadly, this error can happen even if the "aout stream" was well stopped. See
> > MSDN comments in the commit.
> 
> I don´t see why you need to introduce a new member for that.

The selected device was never stored, only the selecting one (used to
pass the request to the MMThread). If the mentioned error happens, you
want to get a new IMMDevice instance of the same device identifier via
IMMDeviceEnumerator_GetDevice() or
IMMDeviceEnumerator_GetDefaultAudioEndpoint(). So you need to store the
previously selected device.

> And the new parameter is very ugly and confusingly named, IMO.

I think it was confusing before, by having sys->dev, the current
IMMDevice and sys->device, the requesting device identified.
What name do you prefer ? requested/requesting instead of
selected/selecting ?

> 
> -- 
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel