[vlc-devel] [RFC PATCH 4/8] input: Allow the sout to change on the fly

[Rémi Denis-Courmont]

Le perjantaina 7. heinäkuuta 2017, 0.28.41 EEST Jean-Baptiste Kempf a écrit :
> On Thu, 6 Jul 2017, at 19:48, Rémi Denis-Courmont wrote:
> > Le torstaina 6. heinäkuuta 2017, 19.14.27 EEST Hugo Beauzée-Luyssen a
> > 
> > écrit :
> > > ---
> > > 
> > >  include/vlc_es_out.h         |  1 +
> > >  src/input/es_out.c           |  9 +++++++++
> > >  src/input/es_out_timeshift.c |  3 +++
> > >  src/input/input.c            | 20 ++++++++++++++++++++
> > >  4 files changed, 33 insertions(+)
> > 
> > Nack. This is broken by design and is not thread-safe.
> 
> Care to share more about this broken by design?

This relies on packetizer and decoder restart, which is, IMO, broken by 
design. It does work to some extent in theory. But it is very broken from user 
experience point of view.

Also considering the big objects orgy between input, ES out(s), demuxer(s) and 
sout instance, I don´t live changing sout or ES out working safely anytime 
soon.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/